Link bid and reveal #896
Merged
Link bid and reveal #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodech
added
wallet-db
nodech
force-pushed
the
update-bidreveal-entries
branch
from
e6144b0
to
5915b31
Compare
nodech
force-pushed
the
update-bidreveal-entries
branch
2 times, most recently
from
50d04e4
to
d566bb2
Compare
bid: Add height to the bid entries.
- Recover bid heights from the TXRecords. Historical not-owned bids will
have them default (-1) for the migration, as TXRecords for them are not
recorded.
- Link owned bid <-> reveals. Historical not-owned bids will have them
default (null outpoint) for the migration, as TXRecords for them are
not recorded.
nodech
force-pushed
the
update-bidreveal-entries
branch
from
14019d1
to
3ae2296
Compare
nodech
force-pushed
the
update-bidreveal-entries
branch
from
84ebf66
to
fd2e57a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals for this PR:
Tasks
NOTE: Not-owned migrated bid and reveals wont have the links, as TX records necessary for it are not recorded. They will instead default to nulls (-1 for bid height, Null Outpoint for reveal). In order to fix this issue, rescan the wallet.
This allows us to do minor release for new APIs that can utilize linked entries for various means. Currently, this does not add API endpoints. Ideally, these APIs will be implemented with #892