Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet: set icannlockup to true for wallets. #885

Merged
merged 1 commit into from
Feb 28, 2024
Merged

wallet: set icannlockup to true for wallets. #885

merged 1 commit into from
Feb 28, 2024

Conversation

nodech
Copy link
Contributor

@nodech nodech commented Jan 16, 2024

After the ICANNLOCKUP has been locked in, walletdb can safely enable this feature and make sure it does not accidentally try to OPEN locked up names.

Wallets using v6 of the hsd, can now also enable icannlockup for the wallet.

@nodech nodech added the wallet part of the codebase label Jan 16, 2024
@coveralls
Copy link

Coverage Status

coverage: 68.628% (+0.002%) from 68.626%
when pulling 4fa9c79 on nodech:wallet-lockup
into 5f94317 on handshake-org:master.

@nodech nodech added this to the hsd 7.0.0 milestone Feb 28, 2024
rithvikvibhu
rithvikvibhu approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@rithvikvibhu rithvikvibhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bob 2.1.0 has this set to true and it's working as expected.

@nodech nodech merged commit f749f5c into handshake-org:master Feb 28, 2024
6 checks passed
@nodech nodech deleted the wallet-lockup branch February 28, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithvikvibhu rithvikvibhu rithvikvibhu approved these changes

Assignees
No one assigned
Labels
wallet part of the codebase
Projects
None yet
Milestone
hsd 7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nodech @coveralls @rithvikvibhu