Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Logging During Tree Sync #668

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Additional Logging During Tree Sync #668

merged 1 commit into from
Dec 9, 2021

Conversation

dills122
Copy link
Contributor

@dills122 dills122 commented Dec 9, 2021

Added additional logging statement to the beginning of the syncTree method to alert users when the processes kicks off since the process could take a few seconds to complete.

@pinheadmz
Copy link
Member

Closes #660

Thank you for contributing!

@coveralls
Copy link

coveralls commented Dec 9, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1559029358

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.008%) to 62.5%
Files with Coverage Reduction New Missed Lines %
lib/covenants/rules.js 1 69.11%
lib/protocol/consensus.js 1 82.79%
Totals Coverage Status
Change from base Build 1558293960: -0.008%
Covered Lines: 21240
Relevant Lines: 31793
💛 - Coveralls

@pinheadmz
Copy link
Member

@dills122 I want to thank you again for your contribution ;-) However at the same moment you were writing this PR I was about to close this same issue in this PR: #669

If you wanna update your branch with the wording I chose for this log message, I'll merge yours first and then rebase so you get the commit ;-)

@dills122
Copy link
Contributor Author

dills122 commented Dec 9, 2021

@pinheadmz No problem! Hoping to get involved more here going forward. Thanks for giving me the commit 😄

@nodech nodech added the quick review difficulty - easy label Dec 9, 2021
@nodech
Copy link
Contributor

nodech commented Dec 9, 2021

Hey, thanks for the contribution !

Can you squash the commits ? That makes master history cleaner w/o redundant commits from the PR.

@nodech nodech added the patch Release version label Dec 9, 2021
@dills122 dills122 force-pushed the blockchain-sync-tree-additional-logging branch from 1f2916a to 8e2e3b4 Compare December 9, 2021 13:55
@nodech
Copy link
Contributor

nodech commented Dec 9, 2021

ACK 8e2e3b4

Show Signature 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK 8e2e3b435e14bed2bb9641f8069a3b4413fa9d83
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEFrhvkEXaY4kUgi4asBinu0N9HwUFAmGyCuYACgkQsBinu0N9
HwX5nw//T6IogzOj628iYGS706S52vZYZeTtQXiZc55DqxWFiyOfDYzbLwHZqHTE
C/5StSHamLT5JE7P0hMN+3IgiGcksRPmG5LRqerVdC94ZB2nx6Q4WOo73QMj8PGL
miN5pCY7jg99Tl9jyP528bErIGtleH1rmcdMUv2OkrsJBiLtbGlcgEuNMDsP4DnU
jUcdQTQZGYwXpOprtLtnuxaoOuVSgOgg0ylfFpDJyk8QCXoSyXlfUAW/B93RnVZc
7iuWqrfGTbuRCqAA4UbiM247+xD6My1/H/YKhUwDt/JB9zqtj4Zgnr/AYQa355fO
o4XvhU9MycMz31D+ioLi2GCkmH3DaBXdVWvSmdV45I8zMvvnHLOSyU7QdrxBzkkj
VLAR7ND+zPXF5hXFe94QaimL7G0VlsntX5DZJ+6kud3BdiJhIFw3ZmJh25lnmjmk
s92nwIBeh4+ZVHeLAFdn37CXUZWSSQuKr3YIxKAMmFyWgVwE9rR23LCgnoxgK6Ja
xl8fo7NqXC78nnw3UHa5x5EeQIRTZwnLmtEmw12exR+SZh7wHZk+n/cwkSeARb4L
vLc126ZLf8LphERQ6dXwKRk31bgzx+kOMVu93a0B/cb3S/JrEO1q6CN8IpUQMzQ2
QcwBNTkowFL7r+WqiEOyLptZZqGWhcvxGn2Jvb05TVNtv4hoxkY=
=BmFP
-----END PGP SIGNATURE-----

nodech's public key is on keybase

@nodech nodech merged commit b8928ea into handshake-org:master Dec 9, 2021
@pinheadmz pinheadmz mentioned this pull request Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch Release version quick review difficulty - easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dills122 @pinheadmz @coveralls @nodech