Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging of urkel tree roots during synchronisation. #123

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

randomlogin
Copy link
Contributor

Added logging of urkel tree roots during synchronisation.
Also added additional output to hesiod query.
Used in stateless DANE: https://github.com/randomlogin/sane

@randomlogin randomlogin marked this pull request as ready for review January 21, 2024 19:37
@randomlogin randomlogin changed the title Added logging of urkel tree roots during synchronisation. Add logging of urkel tree roots during synchronisation. Jan 21, 2024
@randomlogin
Copy link
Contributor Author

Got a bit messy with C style. I would be happy if someone can provide .clang-format configuration used in hnsd.

src/chain.c Outdated Show resolved Hide resolved
Copy link
Member

@rithvikvibhu rithvikvibhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provide .clang-format configuration used in hnsd

I don't think there is any :(

So I went through the changes and marked the bits I think are new. Can you manually save them without formatting so it matches the rest of the codebase?

And 1 comment about dupe code

src/hesiod.c Outdated Show resolved Hide resolved
src/hesiod.c Show resolved Hide resolved
@randomlogin
Copy link
Contributor Author

Updated style to the original one.
Removed duplicates.

Copy link
Member

@rithvikvibhu rithvikvibhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few things I think

configure.ac Outdated Show resolved Hide resolved
src/hesiod.c Outdated Show resolved Hide resolved
src/hesiod.c Outdated Show resolved Hide resolved
@rithvikvibhu rithvikvibhu merged commit 026b1ce into handshake-org:master Mar 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants