Creating a class with .get() function for quick and convenient loading of datasets #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction called get for quick loading of datasets.
williamjameshandley
requested changes
Mar 21, 2024
unimpeded/unimpeded.py
Outdated
Comment on lines
8
to
12
| def __init__(self, **kwargs): | ||
| self.model = kwargs.pop('model', None) | ||
| self.data = kwargs.pop('data', None) | ||
| self.method = kwargs.pop('method', None) | ||
| """ |
There was a problem hiding this comment.
Use this style
unimpeded/unimpeded.py
Outdated
Comment on lines
25
to
29
|
|
||
| #%% | ||
| database = unimpeded('klcdm', 'bao.sdss_dr16', 'ns', 'local') | ||
| samples = database.get() | ||
| # %% |
There was a problem hiding this comment.
this should be put into a test function in tests/test_unimpeded.py
unimpeded/unimpeded.py
Outdated
Comment on lines
20
to
24
| if self.location == 'hpc': | ||
| samples = read_chains(f"/home/dlo26/rds/rds-dirac-dp192-63QXlf5HuFo/dlo26/{self.method}/{self.model}/{self.dataset}/{self.dataset}_polychord_raw/{self.dataset}") # for hpc | ||
| elif self.location == 'local': | ||
| samples = read_chains(f"../../{self.method}/{self.model}/{self.dataset}/{self.dataset}_polychord_raw/{self.dataset}") | ||
| return samples |
There was a problem hiding this comment.
you should read from self.location, and have 'hpc' and 'local' processing as part of your own personal scripts.
unimpeded/unimpeded.py
Outdated
Comment on lines
14
to
16
| self.model = model | ||
| self.dataset = dataset | ||
| self.method = method |
There was a problem hiding this comment.
these should be arguments of .get. For now one would only want location as a kwarg
… class takes in a file path.
DilyOng
commented
Mar 22, 2024
| location = '/home/dlo26/rds/rds-dirac-dp192-63QXlf5HuFo/dlo26/' | ||
|
|
||
|
|
||
| def test_get(): |
There was a problem hiding this comment.
In test_get(), how can I use assert statement to test whether the correct dataset is loaded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…unction called get for quick loading of datasets.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Checklist:
flake8 unimpeded tests)pydocstyle --convention=numpy unimpeded)python -m pytest)