Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added default rasterization to scatter_plot_2d() #380

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrosep
Copy link

@mrosep mrosep commented Apr 17, 2024

Description

Hello all! Have created a new pull request for rasterizing scatter plots (and maybe other plot kinds too) as increasingly they take a long time to load on certain pdf viewers. This is an old pr but I accidentally closed the other one (lol). The rasterize setting is now embedded deeper in the code (in anesthetic/plot.py in the scatter_plot_2d() function) and rasterizing scatters has been made the default. I've also done away with z_orders as they were a bit awkward and I don't think we need them if we just use the matplotlib keyword argument 'rasterized'? Does anyone see an issue with doing it this way? Let me know your thoughts!

Fixes # (issue)

Checklist:

  • I have performed a self-review of my own code
  • My code is PEP8 compliant (flake8 anesthetic tests)
  • My code contains compliant docstrings (pydocstyle --convention=numpy anesthetic)
  • New and existing unit tests pass locally with my changes (python -m pytest)
  • I have added tests that prove my fix is effective or that my feature works
  • I have appropriately incremented the semantic version number in both README.rst and anesthetic/_version.py

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (79c7bb6) to head (3892b52).

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #380      +/-   ##
===========================================
- Coverage   100.00%   99.67%   -0.33%     
===========================================
  Files           36       36              
  Lines         3052     3053       +1     
===========================================
- Hits          3052     3043       -9     
- Misses           0       10      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant