Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for integer axes creation #322

Merged
merged 5 commits into from
Jul 26, 2023
Merged

Test for integer axes creation #322

merged 5 commits into from
Jul 26, 2023

Conversation

yallup
Copy link
Collaborator

@yallup yallup commented Jul 26, 2023

Description

Introduces a make_Nd_axes test for integer axis creation with a few different patterns

Addresses request raised in #321

Checklist:

  • I have performed a self-review of my own code
  • My code is PEP8 compliant (flake8 anesthetic tests)
  • My code contains compliant docstrings (pydocstyle --convention=numpy anesthetic)
  • New and existing unit tests pass locally with my changes (python -m pytest)
  • I have added tests that prove my fix is effective or that my feature works
  • I have appropriately incremented the semantic version number in both README.rst and anesthetic/_version.py

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d3aafc2) 100.00% compared to head (d16a80c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #322   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        33           
  Lines         2790      2792    +2     
=========================================
+ Hits          2790      2792    +2     
Files Changed Coverage Δ
anesthetic/_version.py 100.00% <100.00%> (ø)
anesthetic/plot.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@williamjameshandley williamjameshandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think that squashes this bug, and now is more robust to mixed indices. If you approve, please squash and merge @yallup

@yallup yallup merged commit 0d6618e into handley-lab:master Jul 26, 2023
23 checks passed
@yallup yallup mentioned this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants