Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce helper overhead #1994

Closed
wants to merge 1 commit into from
Closed

Reduce helper overhead #1994

wants to merge 1 commit into from

Conversation

mohd-akram
Copy link
Contributor

This results in about a 30% improvement in a helper-heavy template. Utils.extend is expensive to use in any hot path.

jaylinski
jaylinski approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@jaylinski jaylinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, so I guess returning the options-object instead of a shallow clone also works.

@jaylinski jaylinski added this to the 4.7.9 milestone Sep 6, 2023
@kibertoad
Copy link

What is the status on this? Can we help to get this merged?

@mohd-akram mohd-akram mentioned this pull request Sep 1, 2024
Merged
@mohd-akram
Copy link
Contributor Author

Moved to #1993.

@mohd-akram mohd-akram closed this Sep 1, 2024
@mohd-akram mohd-akram deleted the perf-helper branch September 1, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaylinski jaylinski jaylinski approved these changes

@nknapp nknapp Awaiting requested review from nknapp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.7.9
Development

Successfully merging this pull request may close these issues.
3 participants
@mohd-akram @kibertoad @jaylinski