fix: refactor error handling in CustomErrorResponse for improved clarity and consistency

Author: FarhanSaleh

utils/costum_error.go

@@ -1,19 +1,29 @@
 package utils
 
 import (
+	"fmt"
 	"net/http"
 	"strings"
 
 	"github.com/hammer-code/lms-be/domain"
 )
 
+const (
+	ErrDuplicateEmail 	 = "\"uni_users_email\" (SQLSTATE 23505)"
+	ErrWrongPassword  	 = "password"
+	ErrNotFoundSQL       = "sql: no rows in result set"
+)
+
 type CustomHttpError struct {
 	Code int
 	Message string
 	OriginError error
 }
 
 func (e *CustomHttpError) Error() string {
+	if e.OriginError != nil {
+		return fmt.Sprintf("%s: %s", e.Message, e.OriginError.Error())
+	}
 	return e.Message
 }
 
@@ -41,8 +51,8 @@ func NewInternalServerError(err error) *CustomHttpError {
 	}
 }
 
-func CheckError(err, sub, message string, code int) (domain.HttpResponse, bool) {
-	if strings.Contains(err, sub) {
+func CheckError(errStr, containsStr, message string, code int) (domain.HttpResponse, bool) {
+	if strings.Contains(errStr, containsStr) {
 		return domain.HttpResponse{
 			Code:    code,
 			Message: message,
@@ -52,19 +62,23 @@ func CheckError(err, sub, message string, code int) (domain.HttpResponse, bool)
 }
 
 func CustomErrorResponse(err error) domain.HttpResponse {
+	fmt.Println("YOW", err)
 	if customErr, ok := err.(*CustomHttpError); ok {
-		errStr := customErr.OriginError.Error()
-		resp, ok := CheckError(errStr, "\"uni_users_email\" (SQLSTATE 23505)", "User already exist", 400)
+		var errStr string
+		if customErr.OriginError != nil {
+			errStr = customErr.OriginError.Error()
+		}
+		resp, ok := CheckError(errStr, ErrDuplicateEmail, "User already exist", 400)
 		if ok {
 			return resp
 		}
 
-		resp, ok = CheckError(errStr, "\"uni_logout_token\" (SQLSTATE 23505)", "You have already logged out.", 400)
+		resp, ok = CheckError(errStr, ErrWrongPassword, "Sorry, your password is incorrect", 400)
 		if ok {
 			return resp
 		}
 
-		resp, ok = CheckError(errStr, "password", "Sorry, your password is incorrect", 400)
+		resp, ok = CheckError(errStr, ErrNotFoundSQL, "Data not found", http.StatusNotFound)
 		if ok {
 			return resp
 		}