fix: improve error handling in user login, logout, and registration usecase

Author: FarhanSaleh

app/users/usecase/login_users.go

@@ -4,6 +4,7 @@ import (
 	"context"
 
 	"github.com/hammer-code/lms-be/domain"
+	"github.com/hammer-code/lms-be/utils"
 	"github.com/sirupsen/logrus"
 	"golang.org/x/crypto/bcrypt"
 )
@@ -12,12 +13,14 @@ func (us *usecase) Login(ctx context.Context, userReq domain.Login) (user domain
 	err = us.dbTX.StartTransaction(ctx, func(txCtx context.Context) error {
 		user, err = us.userRepo.FindByEmail(ctx, userReq.Email)
 		if err != nil {
-			logrus.Error("us.LoginUser: failed to login", err)
+			logrus.Error("us.LoginUser: failed to find user by email", err)
+			err = utils.NewInternalServerError(err)
 			return err
 		}
 
 		if err = bcrypt.CompareHashAndPassword([]byte(user.Password), []byte(userReq.Password)); err != nil {
 			logrus.Error("us.Login: invalid password")
+			err = utils.NewBadRequestError("Email or Password is invalid", err)
 			return err
 		}
 
@@ -26,24 +29,28 @@ func (us *usecase) Login(ctx context.Context, userReq domain.Login) (user domain
 		token = *tokenPtr
 
 		if err != nil {
-			logrus.Error("us.Login: failed to login. ", err)
+			logrus.Error("us.Login: failed to generate token", err)
+			err = utils.NewInternalServerError(err)
 			return err
 		}
 
 		if err = us.userRepo.UnactivateTokenByUser(ctx, user.ID); err != nil {
-			logrus.Error("us.Login: failed to login. ", err)
+			logrus.Error("us.Login: failed to unactivate token", err)
+			err = utils.NewInternalServerError(err)
 			return err
 		}
 		if err = us.userRepo.StoreToken(ctx, token, expiredTime, user.ID); err != nil {
-			logrus.Error("us.Login: failed to login. ", err)
+			logrus.Error("us.Login: failed to store token", err)
+			err = utils.NewInternalServerError(err)
 			return err
 		}
 
 		return nil
 	})
 
 	if err != nil {
-		logrus.Error("us.Login: failed to login. ", err)
+		logrus.Error("us.Login: failed to login", err)
+		err = utils.NewInternalServerError(err)
 		return
 	}
 

app/users/usecase/logout_users.go

@@ -1,12 +1,25 @@
 package usecase
 
-import "context"
+import (
+	"context"
+
+	"github.com/hammer-code/lms-be/utils"
+	"github.com/sirupsen/logrus"
+)
 
 func (us *usecase) Logout(ctx context.Context, token string) error {
 	jwtData, err := us.jwt.VerifyToken(token)
 	if err != nil {
+		logrus.Error("us.LogoutUser: failed to varify token", err)
+		err = utils.NewInternalServerError(err)
 		return err
 	}
 
-	return us.userRepo.LogoutUser(ctx, token, jwtData.ExpiresAt.Time)
+	err = us.userRepo.LogoutUser(ctx, token, jwtData.ExpiresAt.Time)
+	if err != nil {
+		logrus.Error("us.LogoutUser: failed to logout", err)
+		err = utils.NewInternalServerError(err)
+		return err
+	}
+	return err
 }

app/users/usecase/register_users.go

@@ -5,16 +5,18 @@ import (
 
 	"github.com/hammer-code/lms-be/constants"
 	"github.com/hammer-code/lms-be/domain"
+	"github.com/hammer-code/lms-be/utils"
 	"github.com/sirupsen/logrus"
 	"golang.org/x/crypto/bcrypt"
 )
 
 func (us *usecase) Register(ctx context.Context, userReq domain.User) (domain.User, error) {
 	user := domain.User{}
-	if err := us.dbTX.StartTransaction(ctx, func(txCtx context.Context) error {
+	err := us.dbTX.StartTransaction(ctx, func(txCtx context.Context) error {
 		hashPassword, err := bcrypt.GenerateFromPassword([]byte(userReq.Password), bcrypt.DefaultCost)
 		if err != nil {
-			logrus.Error("us.Register: failed to register user", err)
+			logrus.Error("us.Register: failed to hash password", err)
+			err = utils.NewInternalServerError(err)
 			return err
 		}
 
@@ -23,14 +25,18 @@ func (us *usecase) Register(ctx context.Context, userReq domain.User) (domain.Us
 		user, err = us.userRepo.CreateUser(ctx, userReq)
 		if err != nil {
 			logrus.Error("us.Register: failed to register users. ", err)
-
+			err = utils.NewInternalServerError(err)
 			return err
 		}
 		return nil
 
-	}); err != nil {
-		logrus.Error("us.Register: failed to get users. ", err)
+	})
+
+	if err != nil {
+		logrus.Error("us.Register: failed to register users. ", err)
+		err = utils.NewInternalServerError(err)
 		return domain.User{}, err
 	}
+	
 	return user, nil
 }