Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay before initialising DHT22 #16

Closed
wants to merge 1 commit into from
Closed

Add delay before initialising DHT22 #16

wants to merge 1 commit into from

Conversation

cgmcintyr
Copy link
Collaborator

- Fixes #15
- Defines BUILTIN_LED as pin 13
@layerzerolabs
Copy link
Collaborator

layerzerolabs commented Nov 17, 2017

I see BUILTIN_LED defined in .../Arduino/hardware/espressif/esp32/variants/feather_esp32/pins_arduino.h
static const uint8_t LED_BUILTIN = 13;
#define BUILTIN_LED LED_BUILTIN // backward compatibility
I don't understand the value of (re?)defining this in the sketch?

@cgmcintyr
Copy link
Collaborator Author

Sorry, this may be to do with not including the Arduino/hardware/espressif/esp32/variants/feather_esp32/pins_arduino.h, I'll be sure to remove the definition of BUILTIN_LED from the pull request.

@layerzerolabs
Copy link
Collaborator

Ah yes, I remember you saying you were also using the expressif IDF - fundamentally better I'm sure but for us the main advantage of the arduino IDE is that novices can hack our stuff, widening up participation...

@hamishcunningham
Copy link
Owner

Happy to merge but pending discussion on #15 ...?

@cgmcintyr cgmcintyr closed this Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants