Update formatters.ts #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the length implementation since the user could be copy / pasting a shorter value (which should be formatted as well).
halilb
requested changes
Jan 23, 2021
There was a problem hiding this comment.
Thanks for the PR @fabcall.
I'm afraid this is breaking the formatter though: Try typing 5555 to the card number input. It won't be formatted to 5555 . You may also check the tests are failing by running yarn test.
I think we should cover the case you mentioned though. Can you try fixing it without breaking tests? Also, could you create a test for your case in formatters.test.ts?
|
Hey @halilb , for sure, I'll take a look at this later today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the length implementation since the user could be copy / pasting a shorter value (which should be formatted as well).