This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Fix photos not updated when mediaList prop changes #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
props.mediaList
is internalised as state in the root component, the library will ignore changes inprops.mediaList
, which will break use cases such as adding/deleting photos.Solution: Move the
selected
state from the root component to thePhoto
component.Also avoid using index as the key for the
FlatList
as it breaks the use cases mentioned above.