Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing PHP-Doc PathNotFoundException #109

Merged
merged 3 commits into from
Nov 26, 2023
Merged

Missing PHP-Doc PathNotFoundException #109

merged 3 commits into from
Nov 26, 2023

Conversation

halaxa
Copy link
Owner

@halaxa halaxa commented Nov 18, 2023

On Items.php

/**
     * @return \Generator
     */
    #[\ReturnTypeWillChange]
    public function getIterator()
    {
        return $this->parser->getIterator();
    }

please add @throws PathNotFoundException as it will not be recognised in PHP-Storm as Throwable Exception.

@halaxa
Copy link
Owner

halaxa commented Nov 18, 2023

Hi, I turned this issue into PR, @Jannig89 (sorry, bad idea, your original comment was posted on my behalf). Can you verify it works for you?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b3aa89) 100.00% compared to head (8a6178d) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #109   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       184       184           
===========================================
  Files             17        17           
  Lines            526       526           
===========================================
  Hits             526       526           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@halaxa halaxa merged commit 401766d into master Nov 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants