Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update script.js #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update script.js #51

wants to merge 1 commit into from

Conversation

Imran-imtiaz48
Copy link

Changes:

  1. Used const and let instead of var for better scoping and avoiding potential issues with hoisting.
  2. Removed redundant false argument in event listeners, as it’s the default.
  3. Optimized the tocItems array creation using Array.from() instead of [].slice.call().
  4. Used template literals for easier string interpolation in the path creation.
  5. Simplified logic by using destructuring for targetBounds properties (top, bottom). This version should now be easier to maintain and perform slightly better.

@Imran-imtiaz48
Update script.js
a8cc496 
Changes:
1.	Used const and let instead of var for better scoping and avoiding potential issues with hoisting.
2.	Removed redundant false argument in event listeners, as it’s the default.
3.	Optimized the tocItems array creation using Array.from() instead of [].slice.call().
4.	Used template literals for easier string interpolation in the path creation.
5.	Simplified logic by using destructuring for targetBounds properties (top, bottom).
This version should now be easier to maintain and perform slightly better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Imran-imtiaz48