Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix_integral #81

Merged
merged 1 commit into from
May 9, 2019
Merged

Fix_integral #81

merged 1 commit into from
May 9, 2019

Conversation

asiddi24
Copy link
Collaborator

@asiddi24 asiddi24 commented May 9, 2019 •
edited
Loading

@codecov
Copy link

codecov bot commented May 9, 2019 •
edited
Loading

Codecov Report

Merging #81 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files           8        8           
  Lines        2914     2914           
  Branches      610      611    +1     
=======================================
  Hits         2880     2880           
  Misses          9        9           
  Partials       25       25
Impacted Files Coverage Δ
oceanspy/compute.py 98.57% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc55a8...98fdad5. Read the comment docs.

@asiddi24 asiddi24 requested a review from malmans2 May 9, 2019 20:51
malmans2
malmans2 approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@malmans2 malmans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@asiddi24 asiddi24 merged commit 4d26a03 into hainegroup:master May 9, 2019
malmans2 pushed a commit that referenced this pull request May 20, 2019
@asiddi24
Merge pull request #81 from asiddi24/fix_integral
1e65aac 
Fix_integral
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malmans2 malmans2 malmans2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asiddi24 @malmans2