Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with numpy>=2.0 and + #452

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Conversation

Mikejmnez
Copy link
Collaborator

This PR:

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.62%. Comparing base (569e70c) to head (027f4f2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #452    +/-   ##
========================================
  Coverage   95.62%   95.62%            
========================================
  Files           9        9            
  Lines        5163     5163            
  Branches     1246     1008   -238     
========================================
  Hits         4937     4937            
  Misses        133      133            
  Partials       93       93            
Flag Coverage Δ
unittests 95.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ThomasHaine ThomasHaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the question about oceanspy/utils.py, all looks good. I made a suggestion on the variable type casting.

@Mikejmnez Mikejmnez merged commit e83d557 into hainegroup:main Oct 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drop Python 3.9 from github workflows resolve numpy >= 2.0 discrepancies
2 participants