Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG: Fix many issues, including (hail#14274), with hailctl batch submit introduced in 0.2.127.
Fixes #14274, Replaces #14351 (authored by @jigold) and #14186 (authored by @danking).
This change has low security impact
Dan's original commit message is as follows:
"""
Issues resolved herein:
exit 0
as it exits the test early.orjson
tojson
.--wait
which waits for the submitted batch to complete and exits success only when the batch is success.realpath
which resolves symlinks. In particular, on Mac OS X,/tmp
is a symlink to/private/tmp
and Python's APIs are inconsistent on whether they return a realpath or a path with symlinks. [1]ln -s src dst
means different things depending on whether dst is an extant folder or not. In this PR, I prefer to always be fully explicit so I never rely onln
detecting the destination is a directory and acting differently. Put differently:file_input_to_src_dest
now never returns a file source and a destination folder.real_absolute_cwd()
on the job before wecd
into it.test_dir_outside_curdir
suggests that--file foo/:/
is meant to copy the contents of foo into the root. This cannot be implemented with our symlink strategy (you can't replace the root with a symlink), so I changed the interpretation: a trailing slash on the source is meaningless. If the destination ends in a slash, we "copy into", otherwise we "copy to".[1]:
"""