Naming fixup

ci/ci/github.py

@@ -486,12 +486,12 @@ async def _update_last_known_github_status(self, gh):
                 self.target_branch.state_changed = True
 
     @staticmethod
-    def _overall_review_status_from_latest_reviews_per_login(latest_reviews_per_login):
+    def _overall_review_status_from_latest_state_by_login(latest_state_by_login):
         active_states = [
-            state for state in latest_reviews_per_login.values() if state in ('APPROVED', 'CHANGES_REQUESTED')
+            state for state in latest_state_by_login.values() if state in ('APPROVED', 'CHANGES_REQUESTED')
         ]
 
-        if any(state == 'CHANGES_REQUESTED' for state in latest_reviews_per_login.values()):
+        if any(state == 'CHANGES_REQUESTED' for state in latest_state_by_login.values()):
             return 'changes_requested'
         elif len(active_states) < 2:
             return 'pending'
@@ -509,7 +509,7 @@ async def _update_github_review_state(self, gh):
             if state != 'COMMENTED':
                 latest_state_by_login[login] = state
 
-        review_state = PR._overall_review_status_from_latest_reviews_per_login(latest_state_by_login)
+        review_state = PR._overall_review_status_from_latest_state_by_login(latest_state_by_login)
 
         if review_state != self.review_state:
             self.set_review_state(review_state)