Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Update skylight: 4.3.2 → 5.3.4 (major) #1276

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Oct 18, 2022

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ skylight (4.3.2 → 5.3.4) · Repo · Changelog

Release Notes

5.3.4 (from changelog)

  • [BUGFIX] Fix a middleware response method that was incompatible with Puma >= 6.
  • [IMPROVEMENT] Improved support for Redis v5

5.3.3 (from changelog)

  • [IMPROVEMENT] Track the original class/method name for Sidekiq delayed object proxies
  • [BUGFIX] Fix mongoid probe not activating correctly
  • [BUGFIX] Fix mongo probe not instrumenting clients created before Skylight initialization

5.3.2 (from changelog)

  • [BUGFIX] Fix case-sensitivity issue when computing relative paths

5.3.1 (from changelog)

  • [BUGFIX] Fix Elasticsearch integration for gem versions >= 8.

5.3.0 (from changelog)

  • [FEATURE] Support for Rails 7's load_async.
  • [IMPROVEMENT] skylight doctor now checks glibc compatibility.
  • [BUGFIX] Fix an issue where skylight doctor wouldn't correctly log installation errors.

5.2.0 (from changelog)

  • [FEATURE] Experimental gRPC transport
  • [IMPROVEMENT] Internal native client refactors
  • [IMPROVEMENT] Add Rack::Builder probe to better instrument middlewares in Sinatra and other Builder-based apps
  • [BUGFIX] Fix some internal errors related to Rails 7
  • [BUGFIX] Fix an issue in which trace logging could output the incorrect request ID.
  • [BUGFIX] Fix native extension configuration for arm64 hosts

5.1.1 (from changelog)

  • [BUGFIX] Correct ruby version requirement in skylight.gemspec

5.1.0 (from changelog)

  • [FEATURE] Add experimental tcp-based skylightd (may be enabled with SKYLIGHT_ENABLE_TCP=true)

  • [IMPROVEMENT] Support aarch64-darwin targets (Apple M1)

  • [IMPROVEMENT] Support aarch64-linux-gnu targets

  • [IMPROVEMENT] Support aarch64-linux-musl targets

  • [IMPROVEMENT] Prevent large traces from shutting down the instrumenter

  • [IMPROVEMENT] Avoid 'invalid option' warnings when instrumenting certain Tilt templates in Sinatra

  • [IMPROVEMENT] Decrease verbosity of source locations logs in the debug level.

  • [BREAKING] Remove SKYLIGHT_SSL_CERT_DIR config

  • [BREAKING] Drop support for Ruby 2.5

5.0.1 (from changelog)

  • [IMPROVEMENT] Use argument-forwarding (...) where available in custom instrumentation

5.0.0 (from changelog)

  • [FEATURE] Add normalizer for Shrine events (thanks @janko!)

  • [FEATURE] Source Locations detection and reporting is now enabled by default (can be disabled with SKYLIGHT_ENABLE_SOURCE_LOCATIONS=false)

  • [FEATURE] Configuration for the Source Locations caches via SYLIGHT_SOURCE_LOCATION_CACHE_SIZE

  • [IMPROVEMENT] Improve keyword argument handling in Skylight::Helpers (thanks @lukebooth!)

  • [IMPROVEMENT] Replace a Kernel.puts with Skylight.log (thanks @johnnyshields!)

  • [IMPROVEMENT] Various updates to the SQL lexer

  • [IMPROVEMENT] Reduce volume of log messages sent to the native logger in debug level

  • [IMPROVEMENT] Optimizations for the Source Locations extension

  • [IMPROVEMENT] Improved Delayed::Job probe

  • [IMPROVEMENT] Maintain method visibility when instrumenting with instrument_method

  • [IMPROVEMENT] Update probes to use Module#prepend where possible

  • [IMPROVEMENT] New tokio-based skylightd

  • [IMPROVEMENT] Support render_layout notifications in Rails 6.1

  • [IMPROVEMENT] Support ActionMailer::MailDeliveryJob in Rails 6.1

  • [IMPROVEMENT] Better logging config. SKYLIGHT_NATIVE_LOG_LEVEL now defaults to warn.

  • [BREAKING] Rename environment keyword argument to priority_key. Note env has not changed.

  • [BREAKING] Drop support for Ruby 2.4

  • [BREAKING] Merge skylight-core into skylight. All classes previously namespaced under Skylight::Core have been moved to Skylight.

  • [BREAKING] Remove Skylight::Util::Inflector

  • [BREAKING] Drop support for Rails 4

  • [BREAKING] Drop support for Ruby 2.3

  • [BUGFIX] Fix issue with missing metadata in MongoDB probe

  • [BUGFIX] Resolve an inability to parse certain SQL queries containing arrays

  • [BUGFIX] Allow multiple probes to be registered under the same key

  • [BUGFIX] Do not refer to Redis constant until the probe is installed

  • [BUGFIX] Fix nested calls to Normalizers::Faraday::Request.disable

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

🗑️ skylight-core (removed)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@janosrusiczki
Copy link
Collaborator

@depfu rebase

@depfu depfu bot force-pushed the depfu/update/skylight-5.3.4 branch from 4838606 to f157421 Compare November 17, 2022 19:45
@depfu depfu bot force-pushed the depfu/update/skylight-5.3.4 branch from f157421 to b4615c1 Compare February 23, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant