Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose pagination API #6

Merged
merged 1 commit into from
Jan 19, 2025
Merged

fix: expose pagination API #6

merged 1 commit into from
Jan 19, 2025

Conversation

hadrien
Copy link
Owner

@hadrien hadrien commented Jan 19, 2025

Problem

  • Pagination API elements are not exposed in __all__
  • Tests do not cover how session dependency writes in DB

Solution

  • Expose Base, Collection, Item, Page, Paginate, PaginateType, new_pagination;
  • Add tests covering more session dependency usage:
    • Add a test that writes a row in db.
    • Add a test that fails on an integrity error.

Next

  • Write documentation

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c0903c4) to head (bb599df).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           92        93    +1     
  Branches         6         6           
=========================================
+ Hits            92        93    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Expose Base, Collection, Item, Page, Paginate, PaginateType,
  new_pagination;
* Add tests covering session dependency usage;
@hadrien hadrien changed the title chore: add tests covering session dependency usage fix: expose pagination API Jan 19, 2025
@hadrien hadrien merged commit 7054d97 into main Jan 19, 2025
4 checks passed
@hadrien hadrien deleted the chore/tests branch January 19, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant