Change: drop python3.6 (#225)

hadialqattan · Nov 14, 2023 · 6770dd0 · 6770dd0
1 parent e15df2e
commit 6770dd0
Show file tree

Hide file tree

Showing 9 changed files with 466 additions and 460 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -37,7 +37,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-20.04, windows-latest, macos-latest]
-        python-version: ["3.6", "3.7", "3.8", "3.9", "3.10"]
+        python-version: ["3.7", "3.8", "3.9", "3.10"]
 
     steps:
       - uses: actions/checkout@v4

diff --git a/.github/workflows/fuzz.yml b/.github/workflows/fuzz.yml
@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-20.04
     strategy:
       matrix:
-        python-version: ["3.6", "3.7", "3.8", "3.9", "3.10"]
+        python-version: ["3.7", "3.8", "3.9", "3.10"]
 
     steps:
       - uses: actions/checkout@v4

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -35,7 +35,7 @@ repos:
     rev: v2.31.1
     hooks:
       - id: pyupgrade
-        args: [--py36-plus]
+        args: [--py37-plus]
 
   - repo: https://github.com/pycqa/isort
     rev: 5.11.5

diff --git a/README.md b/README.md
@@ -47,7 +47,7 @@
 
 ### Installation
 
-Pycln requires Python 3.6+ and can be easily installed using the most common Python
+Pycln requires Python 3.7+ and can be easily installed using the most common Python
 packaging tools. We recommend installing the latest stable release from PyPI with pip:
 
 ```bash

diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -10,6 +10,8 @@ this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 ## [Unreleased]
 
+- [Drop Python3.6 by @hadialqattan](https://github.com/hadialqattan/pycln/pull/225)
+
 ## [2.3.0] - 2023-10-14
 
 ### Changed

diff --git a/docs/README.md b/docs/README.md
@@ -43,7 +43,7 @@
 
 ## Latest Release (PYPI)
 
-Pycln requires Python 3.6+ and can be easily installed using the most common Python
+Pycln requires Python 3.7+ and can be easily installed using the most common Python
 packaging tools. We recommend installing the latest stable release from PyPI with pip:
 
 ```bash

diff --git a/poetry.lock b/poetry.lock
diff --git a/pycln/utils/transform.py b/pycln/utils/transform.py
@@ -45,7 +45,6 @@ def refactor_import_star(self, updated_node: cst.ImportFrom) -> cst.ImportFrom:
         is_multiline = len(self._used_names) > 3
         used_aliases: List[cst.ImportAlias] = []
         for name in self._used_names:
-
             # Skip any dotted name in order
             # to avoid names collision.
             if "." in name:
@@ -161,6 +160,7 @@ def _stylize(
         # (Preserving `node` style).
 
         # Set the trailing comma determined by `_set_trailing_comma`.
+        used_aliases = list(used_aliases)
         used_aliases[-1] = used_aliases[-1].with_changes(comma=self._trailing_comma)
         node = cast(ImportT, node.with_changes(names=used_aliases))
         # Preserving multiline nodes style.

diff --git a/pyproject.toml b/pyproject.toml
@@ -9,7 +9,6 @@ keywords = ["formatter", "linter", "quality-assurance", "tools", "cli"]
 classifiers = [
     "License :: OSI Approved :: MIT License",
     "Programming Language :: Python",
-    "Programming Language :: Python :: 3.6",
     "Programming Language :: Python :: 3.7",
     "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
@@ -24,13 +23,12 @@ packages = [{ include = "pycln" }, { include = "vendor" }]
 pycln = "pycln.cli:app"
 
 [tool.poetry.dependencies]
-python = ">=3.6.2, <4"
+python = ">=3.7.0, <4"
 typer = ">=0.4.1"
-dataclasses = {version = "^0.7", python = "3.6"}
 pyyaml = ">=5.3.1"
 pathspec = ">=0.9.0"
 tomlkit = ">=0.11.1"
-libcst = [{version = ">=0.3.10", python = ">=3.7"}, {version = ">=0.3.10,<0.4.0", python = "<3.7"}]
+libcst = ">=0.3.10"
 
 [tool.poetry.dev-dependencies]
 requests = "^2.24.0"