Merge pull request #23 from piti6/mkim/fix-cs0121

Fix CS0121 on calling LifeTimeScope.CreateChild() / LifeTimeScope.CreateChildFromPrefab(prefab)
hadashiA · Jul 26, 2020 · 101e26c · 101e26c
2 parents 71451fa + 2b0eb4c
commit 101e26c
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/VContainer/Assets/VContainer/Runtime/Unity/LifetimeScope.cs b/VContainer/Assets/VContainer/Runtime/Unity/LifetimeScope.cs
@@ -184,13 +184,13 @@ public LifetimeScope CreateChild(IInstaller installer = null)
             return child;
         }
 
-        public LifetimeScope CreateChild(Action<IContainerBuilder> installation = null)
+        public LifetimeScope CreateChild(Action<IContainerBuilder> installation)
         {
             if (installation != null)
             {
                 return CreateChild(new ActionInstaller(installation));
             }
-            return CreateChild((IInstaller)null);
+            return CreateChild();
         }
 
         public LifetimeScope CreateChildFromPrefab(LifetimeScope prefab, IInstaller installer = null)
@@ -213,13 +213,13 @@ public LifetimeScope CreateChildFromPrefab(LifetimeScope prefab, IInstaller inst
             return child;
         }
 
-        public LifetimeScope CreateChildFromPrefab(LifetimeScope prefab, Action<IContainerBuilder> installation = null)
+        public LifetimeScope CreateChildFromPrefab(LifetimeScope prefab, Action<IContainerBuilder> installation)
         {
             if (installation != null)
             {
                 return CreateChildFromPrefab(prefab, new ActionInstaller(installation));
             }
-            return CreateChildFromPrefab(prefab, (IInstaller)null);
+            return CreateChildFromPrefab(prefab);
         }
 
         void InstallTo(IContainerBuilder builder)