This repository has been archived by the owner on Mar 5, 2020. It is now read-only.
Leaflet map plus data #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… GeoJSON below map in plain JSX.
…mographic data. Donut chart and neighborhood title change as expected on click.
…ed variable and property of RechartsPie “legendStyles” to clarify from previous “styles”. Removed unnecessary style attributes in legendStyles. Added positioning offsets to the legendStyles in both RechartsPie and LeafletPlusData.
dsdemaria
requested review from
oovg and
DavideDaniel
and removed request for
oovg and
DavideDaniel
|
Is this map specific to the housing project? @dsdemaria ? |
|
Yes it is, and I don't think it would make much sense in the component library by itself. It could work as an example on how to use the map, but it would need to be refactored. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue thread #33.
This component is a first pass demo of a react-leaflet map with a GeoJSON layer. The GeoJSON data has been extended with additional mock data, which is then rendered below the map on click events to approximate the housing team's wireframe posted in issue #33.
Also worth noting that I revised the positioning strategy for the RechartsPie legend. I used top and left offsets in the legendStyle object defined in the RechartsPie and LeafletPlusData stories. This addresses the initial render position bug mentioned in #35. The IconType property on the legend is also not rendering as expected—again, originally noted in #35.