Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT REVIEW: Prettier and research on setup via CL and Plugin #5023

Draft
wants to merge 36 commits into
base: gh-pages
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
bd8be66
Add eslint github action
ronaldpaek Jul 15, 2023
68c5ec3
Add eslint config file
ronaldpaek Jul 15, 2023
f236f60
Update eslint github action
ronaldpaek Jul 15, 2023
c666726
Update eslint github file
ronaldpaek Jul 15, 2023
1b76594
Fix eslint github action
ronaldpaek Jul 15, 2023
74850ba
Update eslint config settings
ronaldpaek Jul 15, 2023
3e58995
Initialize Node.js and install Husky for pre-commit checks
ronaldpaek Jul 15, 2023
196f16d
Add unsued variables to test eslint
ronaldpaek Jul 15, 2023
39a5fcf
Add more rules to eslint config
ronaldpaek Jul 15, 2023
8a4575e
Change variable and data to test
ronaldpaek Jul 15, 2023
f70690f
Update github actions to work for any branch push
ronaldpaek Jul 15, 2023
ceec32f
Edit eslint github actions settings
ronaldpaek Jul 15, 2023
376a0df
Add lint staged npm package
ronaldpaek Jul 15, 2023
21c0d15
Edit pre commit hook to run lint stage
ronaldpaek Jul 15, 2023
80796d9
Edit package.json for new values
ronaldpaek Jul 15, 2023
4bb4a11
Fix filename for eslint to eslintrc.json
ronaldpaek Jul 15, 2023
052cf4c
Update linter yaml file to correct wrong value
ronaldpaek Jul 15, 2023
2a76969
Remove standard style from eslint
ronaldpaek Jul 15, 2023
f151b56
Update husky config files
ronaldpaek Jul 15, 2023
fa198ca
Update to use slim image linter
ronaldpaek Jul 15, 2023
dc0250d
Edit file
ronaldpaek Jul 15, 2023
f51c1b0
Remove bad data
ronaldpaek Jul 15, 2023
a429f9b
Add changes to file to fix eslint error
ronaldpaek Jul 15, 2023
1a8876a
Install eslint-config-prettier and prettier
ronaldpaek Jul 16, 2023
5be7c6b
Add some settings for prettier
ronaldpaek Jul 16, 2023
d22b6db
Adjust settings for eslint and lintstage
ronaldpaek Jul 16, 2023
13d21b7
Add prettierignore file
ronaldpaek Jul 16, 2023
d823119
Set prettier back to default styling
ronaldpaek Jul 16, 2023
eb10127
Bad code example
ronaldpaek Jul 16, 2023
ec44ead
Add bad code
ronaldpaek Jul 16, 2023
b102330
Bad css
ronaldpaek Jul 16, 2023
db4a335
Add some bad code
ronaldpaek Jul 16, 2023
fc140e6
Update eslintrc.json to use eslint-config-prettier
ronaldpaek Jul 19, 2023
d246e19
Update json setting to remove EOL setting
ronaldpaek Jul 19, 2023
48946e1
Add .gitattributes file and text=auto to normalize EOL
ronaldpaek Jul 19, 2023
ada95b2
Normalized files to rules defined in .gitattribute config
ronaldpaek Jul 19, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"env": {
"browser": true,
"es2021": true,
"node": true
},
"extends": ["plugin:prettier/recommended", "prettier"],
"parserOptions": {
"ecmaVersion": "latest",
"sourceType": "module"
},
"rules": {
}
}
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* text=auto
6 changes: 3 additions & 3 deletions .github/workflows/lint-scss.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: Lint SCSS

on:
pull_request:
branches: [gh-pages]
# branches: [gh-pages]
push:
branches: [gh-pages]
# branches: [gh-pages]

jobs:
build:
Expand All @@ -19,7 +19,7 @@ jobs:
fetch-depth: 0

- name: Lint SCSS
uses: github/super-linter@v5.0.0
uses: super-linter/super-linter/slim@v5
env:
VALIDATE_ALL_CODEBASE: false
DEFAULT_BRANCH: gh-pages
Expand Down
33 changes: 33 additions & 0 deletions .github/workflows/linter-js.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: Lint JS


on:
pull_request:
# branches: [gh-pages]
push:
# branches: [gh-pages]

jobs:
build:
name: Lint JS
runs-on: ubuntu-latest

steps:
- name: Checkout Code
uses: actions/checkout@v3
with:
# Full git history is needed to get a proper list of changed files within `super-linter`
fetch-depth: 0

# Run Linter against code base #
- name: Lint JS
uses: super-linter/super-linter/slim@v5
env:
VALIDATE_ALL_CODEBASE: false
DEFAULT_BRANCH: gh-pages
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}


LINTER_RULES_PATH: /
JAVASCRIPT_ES_CONFIG_FILE: .eslintrc.json
VALIDATE_JAVASCRIPT_ES: true
4 changes: 4 additions & 0 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

npm run pre-commit
6 changes: 6 additions & 0 deletions .lintstagedrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"*.css": ["stylelint", "prettier --write"],
"*.scss": ["stylelint --syntax=scss", "prettier --write"],
"*.js": ["eslint", "prettier --write"],
"*.{md,html}": "prettier --write"
}
3 changes: 3 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Ignore artifacts:
build
coverage
1 change: 1 addition & 0 deletions .prettierrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
10 changes: 7 additions & 3 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@
// - \n: LF
// - \r\n: CRLF
// - auto: Uses operating system specific end of line character.
"files.eol": "\n",
// "files.eol": "\n",

// Format a file on save. A formatter must be available, the file must not be saved after delay, and the
// editor must not be shutting down.
"editor.formatOnSave": false
}
// "editor.formatOnSave": false

"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": true,
"editor.formatOnPaste": false
}
54 changes: 27 additions & 27 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,27 +1,27 @@
# Website
Hack for LA's website: https://www.hackforla.org
Please refer to the [wiki](https://github.com/hackforla/website/wiki) to learn more about the following areas.
1. Project Definition
2. Joining the Team
3. Tools by Role
4. Resources by Role
5. Agendas
6. Project Terminology
This is a standard [Jekyll](https://jekyllrb.com/) site hosted right here on [GitHub pages](https://pages.github.com/).
## Contributing
We require all Code Contributors to
1. Join our organization by going through [Hack for LA onboarding](https://www.hackforla.org/getting-started). It's free to join!
2. Read the [onboarding section of our WIKI](https://github.com/hackforla/website/wiki/Joining-the-HackforLA.org-Website-Team).
3. Read our [CONTRIBUTING](https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md) document and follow the steps.
## We Love Our Stars ⭐⭐⭐
Thanks to the following people who have given us a star on our repo:
[![Stargazers repo roster for @hackforla/website](https://reporoster.com/stars/hackforla/website)](https://github.com/hackforla/website/stargazers)
# Website

Hack for LA's website: https://www.hackforla.org

Please refer to the [wiki](https://github.com/hackforla/website/wiki) to learn more about the following areas.

1. Project Definition
2. Joining the Team
3. Tools by Role
4. Resources by Role
5. Agendas
6. Project Terminology

This is a standard [Jekyll](https://jekyllrb.com/) site hosted right here on [GitHub pages](https://pages.github.com/).

## Contributing

We require all Code Contributors to

1. Join our organization by going through [Hack for LA onboarding](https://www.hackforla.org/getting-started). It's free to join!
2. Read the [onboarding section of our WIKI](https://github.com/hackforla/website/wiki/Joining-the-HackforLA.org-Website-Team).
3. Read our [CONTRIBUTING](https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md) document and follow the steps.

## We Love Our Stars ⭐⭐⭐

Thanks to the following people who have given us a star on our repo:
[![Stargazers repo roster for @hackforla/website](https://reporoster.com/stars/hackforla/website)](https://github.com/hackforla/website/stargazers)
22 changes: 11 additions & 11 deletions _data/internal/credits/commofpract.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
---
title: Meeting
title-link: https://thenounproject.com/term/meeting/28970/
content-type: image
used-in: Getting Started
artist: froz
provider: Freepik
provider-link: 'https://www.figma.com/'
image-url: /assets/images/getting-started/icon-comm-of-prac-discu.svg
alt: 'Meeting Icon'
---
---
title: Meeting
title-link: https://thenounproject.com/term/meeting/28970/
content-type: image
used-in: Getting Started
artist: froz
provider: Freepik
provider-link: 'https://www.figma.com/'
image-url: /assets/images/getting-started/icon-comm-of-prac-discu.svg
alt: 'Meeting Icon'
---
18 changes: 9 additions & 9 deletions _data/internal/credits/cwmoss.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
---
title: unknown
title-link:
content-type: image
used-in: Not Today Project Logo
artist: C.W. Moss
provider: The Grey Rainbow
provider-link: http://greyrainbow.com/
image-url: assets/images/projects/not-today.png
---
title: unknown
title-link:
content-type: image
used-in: Not Today Project Logo
artist: C.W. Moss
provider: The Grey Rainbow
provider-link: http://greyrainbow.com/
image-url: assets/images/projects/not-today.png
---
Loading