update userprofile to mui #1766
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trillium
reviewed
Oct 22, 2024
| <div className="profile__header"> | ||
| <h3 className="profile__title">My Profile</h3> | ||
| </div> | ||
| <Box> |
There was a problem hiding this comment.
Eventually change hex code to a stored variable, but for now this fine
| </div> | ||
| <Box> | ||
| <Box style={{ backgroundColor: '#bad3ff' }}> | ||
| <Typography |
There was a problem hiding this comment.
Curious if one of these is redundant, I tought that Typography variant="h3" would make this component an h3 element already
| <Typography | ||
| variant="h3" | ||
| component="h3" | ||
| style={{ |
There was a problem hiding this comment.
We may be able to have this be declared through the MUI config file later on
trillium
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1715
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
[image](
)
Visuals after changes are applied
[image](
)