Added background and illustrations to login page #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzzz-coding
requested review from
MattPereira
and removed request for
MattPereira
bzzz-coding
changed the title
MattPereira
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Fantastic job on this one @bzzz-coding !!! 🐝 🐝 🐝
Loved the decision to responsively size the image and well done with the absolute positioning of the corner dots! 👌
I drafted an issue to handle mobile view to match Figma. Don't feel like you have to take care of it as part of this pr or at all since it makes a good first issue for some new dev
nooriaali9
added
role: backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #444
Changes
Screenshots, if applicable
Login Page with Images