Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1846 redesign header #1871

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

bphan002
Copy link
Member

Fixes #1846

Issue
Current header for all pages does not show this is for the city of LA. Currently, it is just a blue background on the header text.

Changes
The banner will show a skyline of Los Angeles.

Current Banner Display

Screenshot 2024-11-22 at 11 05 18 PM

Updated Banner Display

Screenshot 2024-11-22 at 11 08 15 PM
Screenshot 2024-11-22 at 11 08 21 PM

  • Up to date with main branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

@bphan002 bphan002 self-assigned this Nov 23, 2024
Copy link
Member

@ryanfchase ryanfchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but suggesting to try rebase and remove merge artifacts

@bphan002 bphan002 force-pushed the 1846-redesign-header branch 2 times, most recently from faad9ad to ed4def0 Compare December 16, 2024 21:51
@bphan002 bphan002 force-pushed the 1846-redesign-header branch from ed4def0 to 321be71 Compare December 16, 2024 21:53
@bphan002
Copy link
Member Author

@ryanfchase @traycn I removed most of the merge artifcats, but there is still one there. I'm also seeing a warning message on my local environment now.

Sourcemap for "/Users/billyphan/311-data/node_modules/@duckdb/duckdb-wasm/dist/duckdb-browser-eh.worker.js" points to missing source files

Did something change with the source files for the points from then until now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev: Header redesigns
3 participants