Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor player initialization #781

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Refactor player initialization #781

merged 1 commit into from
Jul 12, 2024

Conversation

toberge
Copy link
Collaborator

@toberge toberge commented Jul 12, 2024 •
edited
Loading

Refactored to

  1. Happen in PlayerFactory rather than the network manager
  2. Avoid duplicate code
  3. Perform identity update within the identity itself

@toberge toberge requested a review from Fueredoriku July 12, 2024 11:09
Fueredoriku
Fueredoriku approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor 👍

@toberge toberge merged commit b2d3ff5 into dev Jul 12, 2024
4 checks passed
@toberge toberge deleted the refactor/player-initialization branch July 12, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fueredoriku Fueredoriku Fueredoriku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Prosjekt-Spill-H22 board
Status: Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@toberge @Fueredoriku