Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic non-combination achievements #772

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Add basic non-combination achievements #772

merged 1 commit into from
Jul 11, 2024

Conversation

toberge
Copy link
Collaborator

@toberge toberge commented Jul 10, 2024 •
edited
Loading

Closes #729

status

  • Win a round (seems to work)
  • Win match of each gamemode
  • Credits to the end
  • All in
  • Clutch
  • Matchpoint

the unchecked ones ain't working

@toberge toberge force-pushed the feature/victory-achievements branch 5 times, most recently from 8cb1061 to a327419 Compare July 10, 2024 22:10
@toberge toberge requested a review from Fueredoriku July 10, 2024 22:10
@toberge toberge marked this pull request as ready for review July 10, 2024 22:10
Fueredoriku
Fueredoriku approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, code seems fine and the test seems to indicate it works as intended 👍

Assets/Textures/chip/chipIconpng.png Outdated Show resolved Hide resolved
@toberge toberge force-pushed the feature/victory-achievements branch from a327419 to 5a95ef9 Compare July 11, 2024 12:15
@toberge toberge merged commit d1c9bb0 into dev Jul 11, 2024
@toberge toberge deleted the feature/victory-achievements branch July 11, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fueredoriku Fueredoriku Fueredoriku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Prosjekt-Spill-H22 board
Status: Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Basic gameplay achievements
2 participants
@toberge @Fueredoriku