Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish le gamemode ui stuff #743

Merged
merged 2 commits into from
Jun 30, 2024
Merged

polish le gamemode ui stuff #743

merged 2 commits into from
Jun 30, 2024

Conversation

toberge
Copy link
Collaborator

@toberge toberge commented Jun 26, 2024

Now with descriptions:

image

Also makes tab group selection wrap around. Cuz why wouldn't it ┗( T﹏T )┛
Also also prevented the selection disappearance on the resolution dropdown. Still some odd hijinks where all those dropdowns become partially shaded for some reason.

Please gib feedback on the descriptions, the one for 30 chips is the only one I'm moderately satisfied with.

Closes part of #742 (not the scoreboard things (yet)) also the scoreboard things:

  • LEADER for players with max kills in SIX ROUNDS
  • CAN WIN for players with 30 chips in FIRST TO 30 CHIPS
  • Pickups reward for chips collected
  • Round X on all gamemodes

@toberge toberge force-pushed the feature/polish-gamemode-ui branch 2 times, most recently from 4c9536b to 5f39eb9 Compare June 27, 2024 21:04
@toberge toberge marked this pull request as ready for review June 27, 2024 21:18
@toberge toberge force-pushed the feature/polish-gamemode-ui branch from 5f39eb9 to 8313656 Compare June 27, 2024 21:18
@toberge toberge requested a review from Fueredoriku June 27, 2024 21:18
@toberge toberge force-pushed the feature/polish-gamemode-ui branch 2 times, most recently from dc8f80a to e8659ef Compare June 28, 2024 22:47
Copy link
Collaborator

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🤠

Haven't been able to test very thoroughly in game as my laptop is currently dying a slow and painful death, but from what I have been able to see this is very nice 👍

Assets/Scripts/Scoreboard/Scoreboard.cs Outdated Show resolved Hide resolved
@toberge toberge force-pushed the feature/polish-gamemode-ui branch from e8659ef to 62fc713 Compare June 30, 2024 09:40
@toberge toberge merged commit 5970378 into dev Jun 30, 2024
@toberge toberge deleted the feature/polish-gamemode-ui branch June 30, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

None yet

2 participants