Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor support and sensitivity setting! #741

Merged
merged 7 commits into from
Jul 12, 2024
Merged

Conversation

CraZyB1336
Copy link
Contributor

@CraZyB1336 CraZyB1336 commented Jun 26, 2024

Cursor now has the ability to select buttons and other UI items in the main menu.
Sensitivity setting is now adjustable with an input field and a slider.
Same with FOV and Zoom FOV

@CraZyB1336 CraZyB1336 self-assigned this Jun 26, 2024
@CraZyB1336 CraZyB1336 marked this pull request as draft June 26, 2024 14:11
@CraZyB1336 CraZyB1336 marked this pull request as ready for review July 8, 2024 18:54
Copy link
Collaborator

@toberge toberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questionable quirks:

  • Volume seems to be multiplied by the volume setting each time you enter the main menu, resulting in gradually lower volume if you've set it < 1
  • The map cards are oddly hard to select with the mouse, it seems like the selection is stuck on the first item until you hover over the one that is selected and then try again?
  • Focusing on a tab causes focus to effectively be lost if you try to navigate using keyboard from there

Other than that, it's real nice to have some proper options and be able to use the mouse in the menu.

Assets/Scripts/Control&amp;Input/PlayerMovement.cs Outdated Show resolved Hide resolved
Assets/Scripts/SettingsInfo.cs Outdated Show resolved Hide resolved
Assets/Scripts/SettingsInfo.cs Outdated Show resolved Hide resolved
Assets/Scripts/UI/MainMenu/OptionsMenu.cs Outdated Show resolved Hide resolved
Assets/Scripts/UI/MainMenu/OptionsMenu.cs Outdated Show resolved Hide resolved
Assets/Scripts/UI/MainMenu/OptionsMenu.cs Outdated Show resolved Hide resolved
Assets/Scripts/SettingsInfo.cs Outdated Show resolved Hide resolved
Assets/Scripts/UI/MainMenu/OptionsMenu.cs Show resolved Hide resolved
@CraZyB1336
Copy link
Contributor Author

Questionable quirks:

* The map cards are oddly hard to select with the mouse, it seems like the selection is stuck on the first item until you hover over the one that is selected and then try again?

There seems to be some strange hitbox behavior with the cards and the EvenSystem's raycaster. I'll experiment a little further on this issue

Copy link
Collaborator

@toberge toberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@CraZyB1336 CraZyB1336 merged commit ddc537d into dev Jul 12, 2024
@CraZyB1336 CraZyB1336 deleted the fix/refurbish-settings branch July 12, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants