Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to leave lobbies ++ #665

Merged
merged 10 commits into from
May 31, 2024
Merged

Make it possible to leave lobbies ++ #665

merged 10 commits into from
May 31, 2024

Conversation

toberge
Copy link
Collaborator

@toberge toberge commented May 27, 2024

Depends on #661

Closes #670
Closes #671
Closes #662

Stuff done

  • Leave lobby when you leave the lobby
  • Leave lobby when you disconnect
  • Leave lobby when match is over (ideally you'd be back in the lobby again ready for a new match)
  • Players visually leave/enter lobbies (PlayerSelectManager jank fixed/worked around)
  • Clean up lobby leaving code so you rather have OurNetworkManagerThatIsYetToBeRenamed -> SteamManager
  • Disconnects during matches don't break the game (presently the dummy left by the escapee is unkillable, likely due to authority issues)
  • Show correct names (Player 1, 2, etc) in lobby
  • Fix refresh of lobby list after lobby exit or match end
  • Show loading screen when entering training mode
  • Fix chamber-filling animation on loading screen (it only played once 💀)
  • Fix spawnpoint selection (it used player ID, which can be > 3 now)

Stuff planned but not done in this PR

  • Use SetLobbyJoinable(false) to prevent users from joining an ongoing match and so on

@toberge toberge force-pushed the feature/network-fixes branch 13 times, most recently from 0a05dc0 to 75645bb Compare May 28, 2024 21:17
@toberge toberge changed the title aaaaaa Make it possible to leave lobbies ++ May 28, 2024
@toberge toberge mentioned this pull request May 29, 2024
6 tasks
@toberge toberge force-pushed the feature/network-fixes branch 5 times, most recently from b0ce06c to 2801f01 Compare May 29, 2024 17:49
@toberge toberge marked this pull request as ready for review May 29, 2024 19:19
@toberge toberge requested a review from Fueredoriku May 29, 2024 19:19
Copy link
Collaborator

@Fueredoriku Fueredoriku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! I have a few comments, but I'll leave an approve for you to use at your discretion 😁👍

@toberge toberge merged commit 39a9a9e into dev May 31, 2024
@toberge toberge deleted the feature/network-fixes branch May 31, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🎉
2 participants