Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #584, fix color correction for diffuse, add better shadows #653

Merged
merged 1 commit into from
May 20, 2024

Conversation

Fueredoriku
Copy link
Contributor

@Fueredoriku Fueredoriku commented May 19, 2024

Also fixes a problem where color of texture would impact diffuse lighting

@Fueredoriku Fueredoriku requested a review from toberge May 19, 2024 21:13
@Fueredoriku Fueredoriku linked an issue May 19, 2024 that may be closed by this pull request
@Fueredoriku Fueredoriku self-assigned this May 20, 2024
Copy link
Contributor

@toberge toberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have some ways to go with these kinds of edgecases, but things look so much better now 🎉
image
image
image

@Fueredoriku Fueredoriku merged commit b2d0517 into dev May 20, 2024
3 checks passed
@Fueredoriku Fueredoriku deleted the fix/toon-shader branch May 20, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

Remove specular in shadows
2 participants