Add animation to secret names in weapon select #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toberge
approved these changes
May 18, 2024
There was a problem hiding this comment.
The animation looks fancy-scmancy enough 👍
Only issue is that some of the hues are a little too dark (blue appears darker than other colors even though the saturation/lightness is the samme), but this ain't that important.
With this new fancy text, it becomes even more apparent that we should center the gun name vertically inside the name box, since it looks a little awkward right now when the names covers only one line.
|
Added #652 so we remember to fix this later (tm) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animation for secret names in weapon select, excluding "The Starter".