Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mipmapping to player head icons #600

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

Fueredoriku
Copy link
Contributor

Solves #577

@Fueredoriku Fueredoriku self-assigned this Mar 26, 2024
Copy link
Contributor

@toberge toberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fix the issue, but it comes with the caveat of not having a dotted look on lower resolutions (the player heads look like they're regularly filled)

@Fueredoriku
Copy link
Contributor Author

Fueredoriku commented Mar 26, 2024

It's a good enough trade off I think, especially after testing some different alternatives (2* 2, 3* 3 and 4*4 checkerboards) that also produced the Moiré effect at noticable distances. Larger checkerboard patterns than that just looks bad in terms of pixel art imo

@Fueredoriku Fueredoriku merged commit 29a6806 into dev Mar 26, 2024
2 checks passed
@Fueredoriku Fueredoriku deleted the fix/player-icon-moire branch March 26, 2024 23:32
@Fueredoriku Fueredoriku linked an issue Mar 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

Prevent Moiré effect on player head graphics
2 participants