-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "pause" menu #583
Add "pause" menu #583
Conversation
2f3b51f
to
27512a3
Compare
4f45ec5
to
b93aa5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good feature! 😁👍
I have some feedback and one requested change:
Feedback:
- I think we should rename the "Not paused" title to just "Menu" or "Pause Menu"
- The keybind for the gamepadaction of opening the menu should probably be mapped to the right button and not the left. Whic would be "start[gamepad]" instead of "exit[gamepad]". Alternatively it could be both.
Requested change:
- Currently the pause menu breaks zooming. If zooming is performed and the player then pauses and continues the game, zooming will remain broken until player is respawned.
1421c56
to
08969fd
Compare
Fixened |
08969fd
to
13c15cb
Compare
13c15cb
to
d51ee20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback:
- It seems you can't select between buttons with a gamepad
- Opening more than one menu will deselect all buttons for all players except the newest menu
And a bit more nickpicky:
Setting this as draft again since it's waaaay more work than I assumed 🙃 |
Redone in #759 |
Barely solves #138
Closes #586
Closes #585