Revolver body reload #214
Merged
Revolver body reload #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toberge
approved these changes
Aug 5, 2023
There was a problem hiding this comment.
It's great to finally have some actual reload for the basic body, even though it's a little placeholder-y.
The animation looks a little empty when you're just staring at the barrel for some seconds, but meh, that'll be fixed later. The smoke is a nice touch.
Looks a little off with the WIP cog barrel of course:
Other than that, it is now very noticeable that the shotgun has too much ammo, we should consider modifying ammo cap in barrels :)))))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a slooooow reload animation for the starting body so it isn't better than all the other bodies in the game
I plan to further improve this animation in the future by making the player "cram" bullets into the opened slot during the animation, but this is something I want to implement together with actual "gun holding" IK animations. (Will be a whole other PR)