-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved reload for solar body #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just have a few comments regarding the code, and I haven't tested it yet but the changes don't look too significant.
Assets/Scripts/Augment/AugmentImplementations/Solar/SolarBody.cs
Outdated
Show resolved
Hide resolved
Assets/Scripts/Augment/AugmentImplementations/Solar/SolarBody.cs
Outdated
Show resolved
Hide resolved
Names look good but I'd still suggest writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So in addition to that one comment I have reopened: After briefly testing the solar body, I do wish we could lerp between the two states because the transition from animated grid to pure darkness feels quite jarring. Other than that it works great, now it's actually usable, while not entirely OP since other players can bait the solar wielder into dark areas.
I agree that lerp-ing to reload state is nice, but after testing I've concluded that lerping to the inactive state from active removes visual clarity in terms of showing new users what conditions turns the reload off. I kept the sudden change for gameplay concerns in that specific case and added lerp for the other :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's probably fine now, you fixed things
The solar body now actually considers where the sun is, and if there are any obscuring objects to block the sun, making for more intuitive reload mechanics