Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to delete posts from web UI #752

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

cskartikey
Copy link
Member

@cskartikey cskartikey commented Jun 2, 2024

Should close #746

Todo:

  • Figure out a way to check if authenticated user is the owner of the post.

Copy link

vercel bot commented Jun 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scrapbook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2024 5:00am

@lachlanjc
Copy link
Member

lachlanjc commented Jun 3, 2024

📝 Changed routes:

Commit 7e23d59 (https://scrapbook-bt9gnexbi.hackclub.dev).

components/post.js Show resolved Hide resolved
components/post.js Outdated Show resolved Hide resolved
@JosiasAurel
Copy link
Contributor

please add a toast that will indicate to the user the status of the operation (success, error, loading)

Copy link
Contributor

@JosiasAurel JosiasAurel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i should not have the option to delete a post that i did not create from the web interface

@Ranger-NF
Copy link
Member

i should not have the option to delete a post that i did not create from the web interface

I would say one should have the option. I mean, it would be a lot more work to go back to slack to delete it (considering it was posted via slack)

NB: I haven't checked how the code works, I left this comment based on what was said in the earlier comment. Correct me if I said something wrong :)

@JosiasAurel
Copy link
Contributor

i should not have the option to delete a post that i did not create from the web interface

I would say one should have the option. I mean, it would be a lot more work to go back to slack to delete it (considering it was posted via slack)

NB: I haven't checked how the code works, I left this comment based on what was said in the earlier comment. Correct me if I said something wrong :)

I think there's a misunderstanding here. What I meant is that I should not have the option to delete a post that I did not create using my slack account or my web scrapbook account.

@Ranger-NF
Copy link
Member

Aah... My bad. I agree with you then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make it possible to delete a scrapbook post from the web ui
4 participants