Handle card grant top-ups in Disbursement::TransactionsHelper
#11797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Our reporting strategy is logging which makes it unlikely we'll spot regressions as they are introduced 2. I'm fairly certain we're already hitting errors as there's logic downstream that checks the various mappings on pending transactions. Given the small number of transactions we're displaying this seems acceptable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
In #11757 I added a some logic to render the source and destination transactions for disbursements but failed to account for sub-ledgers, which meant card grant top-ups (where both the source and destination event are the same) were rendered in a very chaotic way.
Describe your changes
event, use[event_id, subledger_id].strict_loading(see reasoning in the commit message)Before
After