Add new receipt input partial with support for receipt bin #11660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
sampoder
reviewed
Sep 13, 2025
sampoder
reviewed
Sep 13, 2025
Comment on lines
94
to
99
|
|
||
| def inline_link | ||
| skip_authorization | ||
|
|
||
| @receipts = Receipt.in_receipt_bin.with_attached_file.where(user: current_user).order(created_at: :desc) | ||
| end |
There was a problem hiding this comment.
This can be as simple as current_user.receipts.build
There was a problem hiding this comment.
I chose to skip authorization here since the the /my/inbox page doesn't authorize anything either - what would the policy be checking?
sampoder
reviewed
Sep 13, 2025
sampoder
reviewed
Sep 13, 2025
Comment on lines
+29
to
+32
| this.pasteData(response) | ||
| } | ||
|
|
||
| pasteData(response) { |
There was a problem hiding this comment.
by "pasting" do you mean filling the form?
sampoder
reviewed
Sep 13, 2025
Comment on lines
15
to
20
| const files = this.fileInputTarget.files | ||
| const newFile = files[files.length - 1] | ||
|
|
||
| const html = `<li>${newFile.name}</li>` | ||
| this.listTarget.innerHTML += html | ||
| this.clearButtonTarget.classList.remove('hidden') |
There was a problem hiding this comment.
I think may want to work on the styling a bit more. The list feels a little out of place at the moment.
There was a problem hiding this comment.
worked on a new list that incorporates the file preview (using the payment-docs icon as fallback when there's no preview) - what do you think?
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
https://hackclub.slack.com/archives/C068U0JMV19/p1757243106361769 - it'd be great to be able to choose from the receipt bin when attaching a receipt to a form! Plus, the current input for receipts was already repeated a lot and should be extracted into a partial.
Describe your changes
This extracts the receipt input into a new partial, which integrates the existing file upload with the receipt bin link form, which has also been extracted into a new partial. With the new
receipt-inputStimulus controller, users can upload or link any number of receipts to the form. Receipt data extraction is supported for receipts linked from the bin.On the controller side, each controller will parse the receipts parameter in addition to the file parameter and link them to the new receiptable if authorized.
Screencast.From.2025-09-12.17-51-55.mp4