Skip to content

Added TecnoMap #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added TecnoMap #228

wants to merge 1 commit into from

Conversation

ReLoia
Copy link

@ReLoia ReLoia commented Jun 9, 2025

BrowserBuddy Extension Submission

Project Details

  1. What is the name of your project?
    TecnoMap

  2. How many hours did you spend developing this?
    2.5 (from Hackatime)

  3. What problem does your extension solve, or what makes it unique?
    It allows players of TecnoCraft (a minecraft server) to see themself on their browsers on the server's map website since it is disabled by default because it is a RP.

  4. How many people have tested your extension?
    3 (from FireFox store)

  5. Does your extension work in Chrome and uses Manifest Version 3?
    Yes it work on Chrome, I tested it on Chromium

Copy link

vercel bot commented Jun 9, 2025

@ReLoia is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@crabby605 crabby605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc. @JosiasAurel
Hi there,

I'm not convinced that this PR took 12 hours to make, you said that you have hackatime proof please send a picture of it here. Another thing is that some of the JavaScript code seems to be AI generated, however I'll leave the final decision for Josias.

@ReLoia
Copy link
Author

ReLoia commented Jun 9, 2025

hi crabby, I was wondering what part of this do you think it's AI generated?

also, for the time part, yeah I did a little mistake, since I did this project some time ago for the Minecraft Mod YSWS (HackCraft) I completely forgot that part of the time was also for Java (great part of it actually). I'll modify the PR
image

this was the project
https://github.com/ReLoia/TecnoMap

Also none of the javascript part is AI made, some is from an old extension I made (the popup part) and the rest is code made by me. I challenge you to make AI redo the code of a "closed" (it isn't closed but the code isn't documented) project like BlueMap.
The js code is meant to work on this website https://mappa.tecnocraft.net/

@ReLoia
Copy link
Author

ReLoia commented Jun 9, 2025

I modified the time in the PR message, I calculated the time doing JS + HTML + MARKDOWN from hackatime

@ReLoia ReLoia requested a review from crabby605 June 9, 2025 13:50
Copy link

@crabby605 crabby605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!, your Javascript file looked a little bit odd to me. Everything else looks fine! Josias will do the final review

@ReLoia
Copy link
Author

ReLoia commented Jun 11, 2025

@crabby605 do you know why @JosiasAurel hasn't reviewed this PR yet? Since it looks like he is reviewing the newer PRs :/

Copy link
Member

@JosiasAurel JosiasAurel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments.
also i think you should try do something more than just displaying people on a minecraft map.

@ReLoia
Copy link
Author

ReLoia commented Jun 11, 2025 via email

@ReLoia
Copy link
Author

ReLoia commented Jun 13, 2025

Any update? @JosiasAurel

@JosiasAurel
Copy link
Member

Seeing this now, sorry. Can you share a video demo of the extension? I don't have minecraft

@ReLoia
Copy link
Author

ReLoia commented Jun 16, 2025

Don't worry! Here's the video:

videoo.mp4

@ReLoia
Copy link
Author

ReLoia commented Jun 16, 2025

The resource pack of the game are bugged but it isn't related with the mod nor with the extension.

@ReLoia
Copy link
Author

ReLoia commented Jun 16, 2025

@JosiasAurel (tagging, i hope it isn't a problem)

Copy link
Member

@JosiasAurel JosiasAurel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

humm okay i can't accept this because it's just a wrapper around an existing site

@ReLoia
Copy link
Author

ReLoia commented Jun 23, 2025

Oh, okay, isn't there anything I can do or is the decision final?

@JosiasAurel
Copy link
Member

Oh, okay, isn't there anything I can do or is the decision final?

You could still brainstorm on features to add and add them. But try to add them before the end of wednesday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants