Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone2 #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Milestone2 #33

wants to merge 1 commit into from

Conversation

halliec6
Copy link

@halliec6 halliec6 commented Nov 1, 2022

Milestone: {Milestone #}

Developer: {Full Name}

Pull Request Summary

{Describe the purpose of your pull request}

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit message follows our guidelines
  • The milestone number is specified
  • The developer name is specified
  • The summary is completed

Reviewer Checklist - PULL REQUEST REVIEWER ONLY

IMPORTANT: The rest of the sections in this checklist should only be filled out by authorized pull request reviewers. If you are the individual template contributor, do not fill out the rest of the fields or check the boxes.

NOTE: Milestones can only be completed when all boxes are checked.

  • The code is fully reviewed
  • Meaningful feedback is given
  • Comment that you have reviewed the code
  • This box is checked

@khoa-l khoa-l self-requested a review November 1, 2022 07:08
@khoa-l khoa-l closed this Nov 1, 2022
@khoa-l khoa-l reopened this Nov 1, 2022
Copy link

@khoa-l khoa-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resubmit the pull request with the appropriate information filled out in the template. Also remember that commit messages should follow the Conventional Commit guidelines outlined in the bootcamp notion page here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants