Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formaction on a button fix #92

Merged
merged 5 commits into from
Jan 6, 2024
Merged

Formaction on a button fix #92

merged 5 commits into from
Jan 6, 2024

Commits on Jan 5, 2024

  1. Update formaction demo to show the issue 

    When there's an input field, the formaction on a button doesn't work.

Also add example with no formaction
    @haacked
    haacked committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    19cdd09 View commit details
    Browse the repository at this point in the history

  2. Use the submitter's formaction if specified 

    When clicking a submit button with a formaction, we need to honor that formaction.
    @haacked
    haacked committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    8656c3c View commit details
    Browse the repository at this point in the history

  3. Make sure we reset the formaction on the submit button

    @haacked
    haacked committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    7be1657 View commit details
    Browse the repository at this point in the history

  4. Wrap in try/finally just in case 

    Co-authored-by: Keith Dahlby <[email protected]>
    @haacked @dahlbyk
    haacked and dahlbyk committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    d028b52 View commit details
    Browse the repository at this point in the history

  5. Use const instead of let 

    Co-authored-by: Keith Dahlby <[email protected]>
    @haacked @dahlbyk
    haacked and dahlbyk committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    95b6ad1 View commit details
    Browse the repository at this point in the history