Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split checkbox demo into client-only and remote #91

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Split checkbox demo into client-only and remote #91

merged 5 commits into from
Jan 2, 2024

Conversation

lonix1
Copy link
Contributor

@lonix1 lonix1 commented Jan 1, 2024

Closes #89

@lonix1 lonix1 mentioned this pull request Jan 1, 2024
Closed
dahlbyk
dahlbyk approved these changes Jan 1, 2024
View reviewed changes
Copy link
Collaborator

@dahlbyk dahlbyk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to leave a few suggestions (merge the models, make the validator more interesting), but went ahead and made the changes myself.
msedge_VlNojKHs79

Thoughts?

Controllers/Validations.cs Show resolved Hide resolved
@dahlbyk dahlbyk requested a review from haacked January 1, 2024 22:40
@haacked haacked merged commit 72a642a into haacked:main Jan 2, 2024
1 check passed
@haacked
Copy link
Owner

haacked commented Jan 2, 2024

Thanks!

@lonix1 lonix1 deleted the lonix1-patch-1 branch March 5, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dahlbyk dahlbyk dahlbyk approved these changes

@haacked haacked Awaiting requested review from haacked

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Checkbox validation does not work (verified in demo app)
3 participants
@lonix1 @haacked @dahlbyk