Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Changing CSS Class Names #86

Merged
merged 4 commits into from
Jan 1, 2024
Merged

Document Changing CSS Class Names #86

merged 4 commits into from
Jan 1, 2024

Conversation

lonix1
Copy link
Contributor

@lonix1 lonix1 commented Dec 26, 2023

Closes #34

Copy link
Collaborator

@dahlbyk dahlbyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, please resolve the conflict from merging #88!

Do you know if it's possible to change the server-generated validation class names in ASP.NET Core? Would be handy to include a link to the relevant docs or include example configuration. I'm pretty sure it's not possible to change them in legacy MVC.

@lonix1
Copy link
Contributor Author

lonix1 commented Dec 29, 2023

Oops, please resolve the conflict from merging #88!

Done.

Do you know if it's possible to change the server-generated validation class names in ASP.NET Core? Would be handy to include a link to the relevant docs or include example configuration.

It is possible for Blazor. But I don't know how to do that for Razor Pages or MVC. Would be nice if that were possible as I would prefer to change the css class names on the server (less fiddly).

@dahlbyk
Copy link
Collaborator

dahlbyk commented Dec 29, 2023

Do you know if it's possible to change the server-generated validation class names in ASP.NET Core? Would be handy to include a link to the relevant docs or include example configuration.

It's not:

@dahlbyk dahlbyk changed the title docs Document Changing CSS Class Names Dec 29, 2023
@lonix1
Copy link
Contributor Author

lonix1 commented Dec 29, 2023

Unfortunate. In that case, anything else outstanding for this PR?

@lonix1
Copy link
Contributor Author

lonix1 commented Jan 1, 2024

@dahlbyk Once this PR is merged I can also submit that other PR (I'm not a github expert - having trouble with branching for two PRs for same repo .) Let me know if there's anything else here that you want me to change.

Copy link
Collaborator

@dahlbyk dahlbyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and merge, but we should add a note to clarify that customizing here means client-side validation won't match serve-side validation without a workaround. And maybe link to the AspNetCore issue so maybe more comments urges action.

@dahlbyk dahlbyk merged commit 1e5f387 into haacked:main Jan 1, 2024
1 check passed
@lonix1 lonix1 deleted the patch-2 branch January 1, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Changing css class names
2 participants