Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add form element validation to key methods #85

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

LiteracyFanatic
Copy link
Contributor

Added explicit checks to ensure that key methods related to form validation (validateForm, handleValidated, submitValidForm, focusFirstInvalid, and isValid) are only being called on form elements. This helps prevent potential type errors and clearly identifies incorrect usage of these methods.

Closes #55

Added explicit checks to ensure that key methods related to form validation (`validateForm`, `handleValidated`, `submitValidForm`, `focusFirstInvalid`, and `isValid`) are only being called on form elements. This helps prevent potential type errors and clearly identifies incorrect usage of these methods.
Copy link
Collaborator

@dahlbyk dahlbyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haacked haacked merged commit 97e4cde into haacked:main Jan 2, 2024
1 check passed
@haacked
Copy link
Owner

haacked commented Jan 2, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manually validating a dynamically added form
3 participants