Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly scan messages when the mutated element is a descendant of a form #65

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Properly scan messages when the mutated element is a descendant of a form #65

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bb44e9
Properly scan messages when the mutated element is a descendant of a …
LiteracyFanatic Jul 31, 2023
d2b4570
Check that type of root is Element before using closest
LiteracyFanatic Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,11 @@ export class ValidationService {
// we could use 'matches', but that's newer than querySelectorAll so we'll keep it simple and compatible.
forms.push(root);
}
// If root is the descendant of a form, we want to include that form too.
const containingForm = (root instanceof Element) ? root.closest('form') : null;
if (containingForm) {
forms.push(containingForm);
}

for (let form of forms) {
let validationMessageElements = Array.from(form.querySelectorAll<HTMLElement>('[data-valmsg-for]'));
Expand Down