Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select validation fix #64

Merged
merged 4 commits into from
Jul 30, 2023
Merged

Select validation fix #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
602353f
Fix logic of isFieldValid by checking if equal to undefined rather th…
LiteracyFanatic Jul 28, 2023
e4205a2
Add errors to all validatable elements not just inputs
LiteracyFanatic Jul 28, 2023
c35bb28
Make sure validation summary error is also removed for select
haacked Jul 30, 2023
64482b0
Rebuild scripts
haacked Jul 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dist/aspnet-validation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ var MvcValidationProviders = /** @class */ (function () {
// Handle single and multiple checkboxes/radio buttons.
var elementType = element.type.toLowerCase();
if (elementType === "checkbox" || elementType === "radio") {
var allElementsOfThisName = Array.from(element.form.querySelectorAll("input[name='".concat(element.name, "'][type='").concat(elementType, "']")));
var allElementsOfThisName = Array.from(element.form.querySelectorAll(validatableSelector("[name='".concat(element.name, "'][type='").concat(elementType, "']"))));
for (var _i = 0, allElementsOfThisName_1 = allElementsOfThisName; _i < allElementsOfThisName_1.length; _i++) {
var element_1 = allElementsOfThisName_1[_i];
if (element_1 instanceof HTMLInputElement && element_1.checked === true) {
Expand Down Expand Up @@ -606,7 +606,7 @@ var ValidationService = /** @class */ (function () {
}
}
var fieldUID = _this.getElementUID(field);
return _this.summary[fieldUID] != null;
return _this.summary[fieldUID] === undefined;
};
/**
* Override CSS class name for input validation error. Default: 'input-validation-error'
Expand Down Expand Up @@ -1045,7 +1045,7 @@ var ValidationService = /** @class */ (function () {
this.swapClasses(input, this.ValidationInputCssClassName, this.ValidationInputValidCssClassName);
if (input.form) {
// Adding an error to one input should also add it to others with the same name (i.e. for radio button and checkbox lists).
var inputs = input.form.querySelectorAll("input[name=\"".concat(input.name, "\"]"));
var inputs = input.form.querySelectorAll(validatableSelector("[name=\"".concat(input.name, "\"]")));
for (var i = 0; i < inputs.length; i++) {
this.swapClasses(inputs[i], this.ValidationInputCssClassName, this.ValidationInputValidCssClassName);
var uid = this.getElementUID(inputs[i]);
Expand All @@ -1069,7 +1069,7 @@ var ValidationService = /** @class */ (function () {
this.swapClasses(input, this.ValidationInputValidCssClassName, this.ValidationInputCssClassName);
// Removing an error from one input should also remove it from others with the same name (i.e. for radio button and checkbox lists).
if (input.form) {
var inputs = input.form.querySelectorAll("input[name=\"".concat(input.name, "\"]"));
var inputs = input.form.querySelectorAll(validatableSelector("[name=\"".concat(input.name, "\"]")));
for (var i = 0; i < inputs.length; i++) {
this.swapClasses(inputs[i], this.ValidationInputValidCssClassName, this.ValidationInputCssClassName);
var uid = this.getElementUID(inputs[i]);
Expand Down
2 changes: 1 addition & 1 deletion dist/aspnet-validation.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/aspnet-validation.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export class MvcValidationProviders {
// Handle single and multiple checkboxes/radio buttons.
const elementType = element.type.toLowerCase();
if (elementType === "checkbox" || elementType === "radio") {
const allElementsOfThisName = Array.from(element.form.querySelectorAll(`input[name='${element.name}'][type='${elementType}']`));
const allElementsOfThisName = Array.from(element.form.querySelectorAll(validatableSelector(`[name='${element.name}'][type='${elementType}']`)));
for (let element of allElementsOfThisName) {
if (element instanceof HTMLInputElement && element.checked === true) {
return true;
Expand Down Expand Up @@ -787,7 +787,7 @@ export class ValidationService {
}

let fieldUID = this.getElementUID(field);
return this.summary[fieldUID] != null;
return this.summary[fieldUID] === undefined;
}

/**
Expand Down Expand Up @@ -1055,7 +1055,7 @@ export class ValidationService {

if (input.form) {
// Adding an error to one input should also add it to others with the same name (i.e. for radio button and checkbox lists).
const inputs = input.form.querySelectorAll(`input[name="${input.name}"]`);
const inputs = input.form.querySelectorAll(validatableSelector(`[name="${input.name}"]`));
for (let i = 0; i < inputs.length; i++) {
this.swapClasses(inputs[i],
this.ValidationInputCssClassName,
Expand Down Expand Up @@ -1090,7 +1090,7 @@ export class ValidationService {

// Removing an error from one input should also remove it from others with the same name (i.e. for radio button and checkbox lists).
if (input.form) {
const inputs = input.form.querySelectorAll(`input[name="${input.name}"]`);
const inputs = input.form.querySelectorAll(validatableSelector(`[name="${input.name}"]`));
for (let i = 0; i < inputs.length; i++) {
this.swapClasses(inputs[i],
this.ValidationInputValidCssClassName,
Expand Down